1. 27 Jul, 2022 2 commits
    • Daniel García's avatar
      Merge pull request #2650 from BlackDex/mitigate-mobile-client-uploads · ce9d9300
      Daniel García authored
      Mitigate attachment/send upload issues
      ce9d9300
    • BlackDex's avatar
      Mitigate attachment/send upload issues · abfa8684
      BlackDex authored
      This PR attends to mitigate (not fix) #2644.
      There seems to be an issue when uploading files either as attachment or
      via send via the mobile (Android) client.
      
      The binary data gets transfered correctly to Vaultwarden (Checked via
      Wireshark), but the data is not parsed correctly for some reason.
      
      Since the parsing is not done by Vaultwarden it self, i think we should
      at least try to prevent saving the data and letting users think all
      fine.
      
      Further investigation is needed to actually fix this issue.
      This is just a quick patch.
      abfa8684
  2. 22 Jul, 2022 3 commits
  3. 20 Jul, 2022 1 commit
    • BlackDex's avatar
      Fix persistent folder check within containers · 9a787dd1
      BlackDex authored
      The previous persistent folder check worked by checking if a file
      exists. If you used a bind-mount, then this file is not there. But when
      using a docker/podman volume those files are copied, and caused the
      container to not start.
      
      This change checks the `/proc/self/mountinfo` for a specific patern to
      see if the data folder is persistent or not.
      
      Fixes #2622
      9a787dd1
  4. 19 Jul, 2022 1 commit
    • BlackDex's avatar
      Update build workflow for CI · 0dcc435b
      BlackDex authored
      Because we want to support MSRV, we also need to run a CI for this.
      This PR adds checks for the MSRV and rust-toolchain defined versions.
      
      It will also run all cargo test, clippy and fmt checks no matter the outcome of the previous job.
      This will help when there are multiple issues, like clippy errors and formatting.
      Previously it would show only the first failed check and stopped.
      
      It will also output a nice step summary with some details on which checks have failed.
      Or it will output a success message.
      0dcc435b
  5. 17 Jul, 2022 2 commits
  6. 15 Jul, 2022 9 commits
  7. 10 Jul, 2022 1 commit
    • BlackDex's avatar
      Add more clippy checks for better code/readability · 55d7c48b
      BlackDex authored
      A bit inspired by @paolobarbolini from this commit at lettre https://github.com/lettre/lettre/pull/784 .
      I added a few more clippy lints here, and fixed the resulted issues.
      
      Overall i think this could help in preventing future issues, and maybe
      even peformance problems. It also makes some code a bit more clear.
      
      We could always add more if we want to, i left a few out which i think
      arn't that huge of an issue. Some like the `unused_async` are nice,
      which resulted in a few `async` removals.
      
      Some others are maybe a bit more estatic, like `string_to_string`, but i
      think it looks better to use `clone` in those cases instead of `to_string` while they already are a string.
      55d7c48b
  8. 09 Jul, 2022 4 commits
  9. 08 Jul, 2022 1 commit
    • Yip Rui Fung's avatar
      Add option to make file uploads use move_copy_to instead of persist_to · ebe9162a
      Yip Rui Fung authored
      This is to support scenarios where the attachments and sends folder are to be stored on a separate device from the tmp_folder (i.e. fuse-mounted S3 storage), due to having the tmp_dir on the same device being undesirable.
      
      Example being fuse-mounted S3 storage with the reasoning that because S3 basically requires a copy+delete operations to rename files, it's inefficient to rename files on device, if it's even allowed.
      ebe9162a
  10. 06 Jul, 2022 11 commits
  11. 01 Jul, 2022 3 commits
  12. 26 Jun, 2022 2 commits