1. 01 Mar, 2021 1 commit
  2. 27 Feb, 2021 14 commits
  3. 26 Feb, 2021 1 commit
    • John McLear's avatar
      reversecompat: underscore · c0ec28f7
      John McLear authored
      Backward compatibility for plugins that were written when underscore lived at src/static/js/underscore.js.
      c0ec28f7
  4. 25 Feb, 2021 16 commits
  5. 24 Feb, 2021 4 commits
  6. 23 Feb, 2021 3 commits
  7. 22 Feb, 2021 1 commit
    • John McLear's avatar
      tests: fix importexport tests · 8364546e
      John McLear authored
      The testing approach was redone to fix numerous issues:
        * Even if the tests had been working, none of them would have caught
          https://github.com/ether/etherpad-lite/issues/4808 because they
          didn't exercise the client-side import logic. Now they do.
        * Follow-up logic was not in the `helper.waitFor()` callback like it
          should have been. Now the code uses `async` and `await` to ensure
          proper execution order.
        * All `$.ajax()` calls used `async: false`. Now they're properly
          asynchronous.
        * The `helper.waitFor()` condition callbacks threw instead of
          returning false.
        * The string comparisons didn't allow for different attribute
          order (e.g., `<ol start="1" class="list-number1">` vs. `<ol
          class="list-number1" start="1">`). Now `Node.isEqualNode()` is
          used to reduce fragility. (`Node.isEqualNode()` is not perfect, so
          the tests are still a bit fragile: If class names or style strings
          are in a different order then `Node.isEqualNode()` will return
          false even if the nodes are semantically equivalent.)
      Co-authored-by: default avatarRichard Hansen <rhansen@rhansen.org>
      8364546e