From a6e22e5321df0b4f02460a7d292aaf048d2c6c9f Mon Sep 17 00:00:00 2001
From: Edward Welch <edward.welch@grafana.com>
Date: Thu, 2 May 2019 13:04:55 -0400
Subject: [PATCH] need to remove this return statement or positions will never
be cleaned up
---
pkg/promtail/positions/positions.go | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/pkg/promtail/positions/positions.go b/pkg/promtail/positions/positions.go
index b1e325e7..c1bbee74 100644
--- a/pkg/promtail/positions/positions.go
+++ b/pkg/promtail/positions/positions.go
@@ -138,12 +138,11 @@ func (p *Positions) cleanup() {
if os.IsNotExist(err) {
// File no longer exists.
toRemove = append(toRemove, k)
- return
+ } else {
+ // Can't determine if file exists or not, some other error.
+ level.Warn(p.logger).Log("msg", "could not determine if log file "+
+ "still exists while cleaning positions file", "error", err)
}
- // Can't determine if file exists or not, some other error.
- level.Warn(p.logger).Log("msg", "could not determine if log file "+
- "still exists while cleaning positions file", "error", err)
-
}
}
for _, tr := range toRemove {
--
GitLab