From e4e5e3c1f136045d91e93fcff68c756c745576fc Mon Sep 17 00:00:00 2001 From: Robert Fratto <robert.fratto@grafana.com> Date: Thu, 25 Jul 2019 16:48:09 -0400 Subject: [PATCH] ingester: fix feedback from PR review --- pkg/ingester/ingester.go | 2 +- pkg/ingester/transfer.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/ingester/ingester.go b/pkg/ingester/ingester.go index d1d77b42..cc78087d 100644 --- a/pkg/ingester/ingester.go +++ b/pkg/ingester/ingester.go @@ -173,7 +173,7 @@ func (i *Ingester) Push(ctx context.Context, req *logproto.PushRequest) (*logpro func (i *Ingester) getOrCreateInstance(instanceID string) *instance { inst, ok := i.getInstanceByID(instanceID) - if ok || i.readonly { + if ok { return inst } diff --git a/pkg/ingester/transfer.go b/pkg/ingester/transfer.go index c329dab0..a249ef2a 100644 --- a/pkg/ingester/transfer.go +++ b/pkg/ingester/transfer.go @@ -29,7 +29,7 @@ var ( }) ) -// TransferChunks receieves all chunks from another ingester. The Ingester +// TransferChunks receives all chunks from another ingester. The Ingester // must be in PENDING state or else the call will fail. func (i *Ingester) TransferChunks(stream logproto.Ingester_TransferChunksServer) error { // Entry JOINING state (only valid from PENDING) -- GitLab