From 26e5abf20d9fa15b34a122d0ab5ab6e359852e4c Mon Sep 17 00:00:00 2001
From: Jason Robinson <mail@jasonrobinson.me>
Date: Mon, 7 Jan 2019 18:28:40 +0200
Subject: [PATCH] Fix command hint to generate a config file (#4353)
* Fix command hint to generate a config file
When trying to start Synapse without a config file, it will complain
and give a hint towards what command to run. This hinted command
is missing the "report_stats" parameter, which is required with either
yes or no value. Add this to the command.
Not an ideal situation but makes the given command work without the
user getting another error, even though it might be unclear what
"report_stats" represents.
Signed-off-by: Jason Robinson <jasonr@matrix.org>
---
AUTHORS.rst | 5 ++++-
changelog.d/4353.misc | 1 +
synctl | 4 +++-
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 changelog.d/4353.misc
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 9a83d90153..d599aec74c 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -65,4 +65,7 @@ Pierre Jaury <pierre at jaury.eu>
* Docker packaging
Serban Constantin <serban.constantin at gmail dot com>
- * Small bug fix
\ No newline at end of file
+ * Small bug fix
+
+Jason Robinson <jasonr at matrix.org>
+ * Minor fixes
diff --git a/changelog.d/4353.misc b/changelog.d/4353.misc
new file mode 100644
index 0000000000..b08bd77f3d
--- /dev/null
+++ b/changelog.d/4353.misc
@@ -0,0 +1 @@
+Fix command hint to generate a config file when trying to start without a config file
diff --git a/synctl b/synctl
index 7e79b05c39..816c898b36 100755
--- a/synctl
+++ b/synctl
@@ -156,7 +156,9 @@ def main():
write(
"No config file found\n"
"To generate a config file, run '%s -c %s --generate-config"
- " --server-name=<server name>'\n" % (" ".join(SYNAPSE), options.configfile),
+ " --server-name=<server name> --report-stats=<yes/no>'\n" % (
+ " ".join(SYNAPSE), options.configfile,
+ ),
stream=sys.stderr,
)
sys.exit(1)
--
GitLab