From 6c847785494473c0a430f368a0d79c9202b8ddd0 Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Fri, 7 May 2021 14:54:09 +0100
Subject: [PATCH] Always cache 'event_to_prev_state_group' (#9950)
Fixes regression in send PDU times introduced in #9905.
---
changelog.d/9950.feature | 1 +
synapse/handlers/message.py | 13 +++++++------
2 files changed, 8 insertions(+), 6 deletions(-)
create mode 100644 changelog.d/9950.feature
diff --git a/changelog.d/9950.feature b/changelog.d/9950.feature
new file mode 100644
index 0000000000..96a0e7f09f
--- /dev/null
+++ b/changelog.d/9950.feature
@@ -0,0 +1 @@
+Improve performance of sending events for worker-based deployments using Redis.
diff --git a/synapse/handlers/message.py b/synapse/handlers/message.py
index 8729332d4b..5afb7fc261 100644
--- a/synapse/handlers/message.py
+++ b/synapse/handlers/message.py
@@ -1050,6 +1050,13 @@ class EventCreationHandler:
)
if state_entry.state_group:
+ await self._external_cache.set(
+ "event_to_prev_state_group",
+ event.event_id,
+ state_entry.state_group,
+ expiry_ms=60 * 60 * 1000,
+ )
+
if state_entry.state_group in self._external_cache_joined_hosts_updates:
return
@@ -1057,12 +1064,6 @@ class EventCreationHandler:
# Note that the expiry times must be larger than the expiry time in
# _external_cache_joined_hosts_updates.
- await self._external_cache.set(
- "event_to_prev_state_group",
- event.event_id,
- state_entry.state_group,
- expiry_ms=60 * 60 * 1000,
- )
await self._external_cache.set(
"get_joined_hosts",
str(state_entry.state_group),
--
GitLab