Prefer `make_awaitable` over `defer.succeed` in tests (#12505)
When configuring the return values of mocks, prefer awaitables from
`make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable
once, so it is inappropriate for a mock to return the same `Deferred`
multiple times.
Also update `run_in_background` to support functions that return
arbitrary awaitables.
Signed-off-by:
Sean Quah <seanq@element.io>
Showing
- changelog.d/12505.misc 1 addition, 0 deletionschangelog.d/12505.misc
- synapse/logging/context.py 17 additions, 9 deletionssynapse/logging/context.py
- tests/federation/test_federation_client.py 1 addition, 1 deletiontests/federation/test_federation_client.py
- tests/federation/test_federation_sender.py 1 addition, 1 deletiontests/federation/test_federation_sender.py
- tests/handlers/test_e2e_keys.py 3 additions, 4 deletionstests/handlers/test_e2e_keys.py
- tests/handlers/test_password_providers.py 16 additions, 18 deletionstests/handlers/test_password_providers.py
- tests/handlers/test_typing.py 3 additions, 3 deletionstests/handlers/test_typing.py
- tests/handlers/test_user_directory.py 3 additions, 3 deletionstests/handlers/test_user_directory.py
- tests/rest/client/test_presence.py 2 additions, 2 deletionstests/rest/client/test_presence.py
- tests/rest/client/test_rooms.py 2 additions, 5 deletionstests/rest/client/test_rooms.py
- tests/rest/client/test_transactions.py 4 additions, 3 deletionstests/rest/client/test_transactions.py
- tests/server_notices/test_resource_limits_server_notices.py 14 additions, 14 deletionstests/server_notices/test_resource_limits_server_notices.py
- tests/storage/test_monthly_active_users.py 4 additions, 5 deletionstests/storage/test_monthly_active_users.py
- tests/test_federation.py 1 addition, 1 deletiontests/test_federation.py
Loading
Please register or sign in to comment