From 8711e15734b0d5e24716f16263c2dd15a337d30f Mon Sep 17 00:00:00 2001
From: Patrick Cloke <clokep@users.noreply.github.com>
Date: Tue, 12 Oct 2021 16:09:49 -0400
Subject: [PATCH] Always dump logs from trial during CI. (#11068)
Instead of only dumping them if trial passes.
---
.github/workflows/tests.yml | 6 ++++++
.github/workflows/twisted_trunk.yml | 2 ++
changelog.d/11068.misc | 1 +
3 files changed, 9 insertions(+)
create mode 100644 changelog.d/11068.misc
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 30a911fdbd..9e302bf446 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -122,6 +122,8 @@ jobs:
SYNAPSE_POSTGRES_USER: postgres
SYNAPSE_POSTGRES_PASSWORD: postgres
- name: Dump logs
+ # Logs are most useful when the command fails, always include them.
+ if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair
@@ -146,6 +148,8 @@ jobs:
env:
TRIAL_FLAGS: "--jobs=2"
- name: Dump logs
+ # Logs are most useful when the command fails, always include them.
+ if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair
@@ -176,6 +180,8 @@ jobs:
env:
TRIAL_FLAGS: "--jobs=2"
- name: Dump logs
+ # Logs are most useful when the command fails, always include them.
+ if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair
diff --git a/.github/workflows/twisted_trunk.yml b/.github/workflows/twisted_trunk.yml
index b5c729888f..e974ac7aba 100644
--- a/.github/workflows/twisted_trunk.yml
+++ b/.github/workflows/twisted_trunk.yml
@@ -33,6 +33,8 @@ jobs:
TRIAL_FLAGS: "--jobs=2"
- name: Dump logs
+ # Logs are most useful when the command fails, always include them.
+ if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair
diff --git a/changelog.d/11068.misc b/changelog.d/11068.misc
new file mode 100644
index 0000000000..1fe69aecde
--- /dev/null
+++ b/changelog.d/11068.misc
@@ -0,0 +1 @@
+Always dump logs from unit tests during CI runs.
--
GitLab