Skip to content
Snippets Groups Projects
  1. Dec 04, 2019
  2. Dec 03, 2019
  3. Dec 02, 2019
  4. Nov 29, 2019
  5. Nov 28, 2019
    • Brendan Abolivier's avatar
      Lint · 78ec11c0
      Brendan Abolivier authored
      78ec11c0
    • Brendan Abolivier's avatar
      Changelog · 5ee2beed
      Brendan Abolivier authored
      5ee2beed
    • Brendan Abolivier's avatar
      Discard retention policies when retrieving state · 708cef88
      Brendan Abolivier authored
      Purge jobs don't delete the latest event in a room in order to keep the forward extremity and not break the room. On the other hand, get_state_events, when given an at_token argument calls filter_events_for_client to know if the user can see the event that matches that (sync) token. That function uses the retention policies of the events it's given to filter out those that are too old from a client's view.
      
      Some clients, such as Riot, when loading a room, request the list of members for the latest sync token it knows about, and get confused to the point of refusing to send any message if the server tells it that it can't get that information. This can happen very easily with the message retention feature turned on and a room with low activity so that the last event sent becomes too old according to the room's retention policy.
      
      An easy and clean fix for that issue is to discard the room's retention policies when retrieving state.
      708cef88
Loading