Skip to content
Snippets Groups Projects
  1. Nov 02, 2020
  2. Oct 30, 2020
  3. Oct 29, 2020
  4. Oct 28, 2020
  5. Oct 27, 2020
    • Dan Callahan's avatar
      Tell Black to format code for Python 3.5 (#8664) · aff1eb7c
      Dan Callahan authored
      
      This allows trailing commas in multi-line arg lists.
      
      Minor, but we might as well keep our formatting current with regard to
      our minimum supported Python version.
      
      Signed-off-by: default avatarDan Callahan <danc@element.io>
      aff1eb7c
    • Dan Callahan's avatar
      Minor updates to docs on how to run tests (#8666) · e90fad5c
      Dan Callahan authored
      
      The test runner isn't present in the `[all]` set of extras, so the
      previous instructions did not work without also installing `[test]`.
      
      Note that this does not include the `[lint]` extras, since those do not
      install on all supported Python versions (specifically, isort 5.x
      requires Python 3.6, while we still support 3.5). Instructions for that
      are included in our pull request template, so we should be fine there.
      
      I've also dropped the `--no-use-pep517` arg to `pip install` since it
      seems to have been added to address a temporary regression in pip 19.1
      which was fixed in pip 19.1.1 the following month.
      
      Lastly, updated the example output of the test suite to set more
      realistic expectations around run time.
      
      Signed-off-by: default avatarDan Callahan <danc@element.io>
      e90fad5c
    • Dan Callahan's avatar
      Note support for Python 3.9 (#8665) · 88e1d0c5
      Dan Callahan authored
      
      As expected, all tests pass locally without modification.
      
      Signed-off-by: default avatarDan Callahan <danc@element.io>
      88e1d0c5
    • Michael Kaye's avatar
    • Andrew Morgan's avatar
      Abstract code for stripping room state into a separate method (#8671) · a699c044
      Andrew Morgan authored
      This is a requirement for [knocking](https://github.com/matrix-org/synapse/pull/6739), and is abstracting some code that was originally used by the invite flow. I'm separating it out into this PR as it's a fairly contained change.
      
      For a bit of context: when you invite a user to a room, you send them [stripped state events](https://matrix.org/docs/spec/server_server/unstable#put-matrix-federation-v2-invite-roomid-eventid) as part of `invite_room_state`. This is so that their client can display useful information such as the room name and avatar. The same requirement applies to knocking, as it would be nice for clients to be able to display a list of rooms you've knocked on - room name and avatar included.
      
      The reason we're sending membership events down as well is in the case that you are invited to a room that does not have an avatar or name set. In that case, the client should use the displayname/avatar of the inviter. That information is located in the inviter's membership event.
      
      This is optional as knocks don't really have any user in the room to link up to. When you knock on a room, your knock is sent by you and inserted into the room. It wouldn't *really* make sense to show the avatar of a random user - plus it'd be a data leak. So I've opted not to send membership events to the client here. The UX on the client for when you knock on a room without a name/avatar is a separate problem.
      
      In essence this is just moving some inline code to a reusable store method.
      a699c044
    • Erik Johnston's avatar
Loading