1. 30 Jul, 2019 2 commits
  2. 12 Jul, 2019 2 commits
  3. 20 May, 2019 2 commits
  4. 07 May, 2019 4 commits
  5. 06 May, 2019 4 commits
  6. 14 Apr, 2019 1 commit
    • Michael Kuhn's avatar
      Fix button focus issues · e38fcd6d
      Michael Kuhn authored
      This change introduces derived classes for ComboButton, DropDownButton
      and Select that make sure that buttons do not remain focused after their
      menus are closed. This allows using hotkeys after closing them.
      e38fcd6d
  7. 13 Apr, 2019 1 commit
    • Michael Kuhn's avatar
      Fix focus issues with hotkeys · 4a2a90c9
      Michael Kuhn authored
      Since making use of keypress in addition to keydown, hotkeys did not
      work in certain scenarios, including clicking on the feed tree expanders
      or empty spaces of the toolbar.
      
      This issue is caused by dijit.Tree and dijit.Toolbar implementing the
      _KeyNavMixin, which explicitly stops propagation of keypress events.
      
      This change contains two main fixes plus a smaller hotfix:
      1. It overrides _onContainerKeydown and _onContainerKeypress for
         fox.FeedTree (which inherits from dijit.Tree).
      2. It adds fox.Toolbar, which overrides _onContainerKeydown,
         _onContainerKeypress and focus. This fixes hotkeys being swallowed
         and the first focusable child receiving focus when clicking on an
         empty space of the toolbar.
      3. It adds the same handling of keydown and keypress to the prefs hotkey
         handler as is done in the main hotkey handler.
      4a2a90c9
  8. 12 Apr, 2019 1 commit
  9. 08 Apr, 2019 1 commit
  10. 14 Mar, 2019 1 commit
  11. 11 Mar, 2019 1 commit
    • Michael Kuhn's avatar
      Refactor hotkeys to use keypress instead of keydown · e74f7bde
      Michael Kuhn authored
      keydown returns the "raw" key in event.which. Depending on the keyboard
      layout, this may not be what is wanted. For example, on a German
      keyboard, Shift+7 has to be pressed to get a slash. However, event.which
      will be 55, which corresponds to "7". In the keypress event, however,
      event.which will be 47, which corresponds to "/".
      
      Sadly, several important keys (such as escape and the arrow keys) do not
      trigger a keypress event. Therefore, they have to be handled using a
      keydown event.
      
      This change refactors the hotkey support to make use of keypress events
      whenever possible. This will make hotkeys work regardless of the user's
      keyboard layout. Escape and arrow keys are still handled via keydown
      events.
      
      There should be only one change in behavior: I could not make Ctrl+/
      work and therefore rebound the help dialog to "?".
      e74f7bde
  12. 08 Mar, 2019 1 commit
  13. 07 Mar, 2019 6 commits
  14. 05 Mar, 2019 1 commit
  15. 21 Feb, 2019 2 commits
  16. 20 Feb, 2019 1 commit
  17. 14 Feb, 2019 1 commit
  18. 01 Feb, 2019 1 commit
  19. 31 Jan, 2019 1 commit
  20. 28 Jan, 2019 2 commits
  21. 27 Jan, 2019 1 commit
  22. 16 Jan, 2019 1 commit
  23. 03 Jan, 2019 1 commit
  24. 02 Jan, 2019 1 commit