Skip to content
Snippets Groups Projects
  1. Jul 25, 2023
  2. Jul 24, 2023
  3. Jul 12, 2023
  4. Jul 02, 2023
  5. Jun 14, 2023
  6. May 22, 2023
  7. May 16, 2023
  8. Apr 30, 2023
  9. Apr 19, 2023
  10. Apr 16, 2023
  11. Mar 31, 2023
  12. Mar 12, 2023
  13. Feb 20, 2023
  14. Feb 18, 2023
  15. Dec 15, 2022
  16. Nov 17, 2022
  17. Nov 16, 2022
  18. Nov 07, 2022
  19. Oct 30, 2022
  20. Oct 05, 2022
  21. Aug 24, 2022
  22. Jun 21, 2022
  23. May 26, 2022
  24. Apr 06, 2022
  25. Mar 09, 2022
    • chandrn7's avatar
      Allow login through OpenID Connect (#16221) · a6ed6845
      chandrn7 authored
      * added OpenID Connect as an SSO option
      
      * minor fixes
      
      * added comments, removed an option that shouldn't be set
      
      * fixed Gemfile.lock
      
      * added newline to end of Gemfile.lock
      
      * removed tab from Gemfile.lock
      
      * remove chomp
      
      * codeclimate changes and small name change to make function's purpose clearer
      
      * codeclimate fix
      
      * added SSO buttons to /about page
      
      * minor refactor
      
      * minor style change
      
      * removed spurious change
      
      * removed unecessary conditional from ensure_valid_username and added support for auth.info.name in user_params_from_auth
      
      * minor changes
      a6ed6845
  26. Mar 01, 2022
    • Claire's avatar
      Change old moderation strikes to be displayed in a separate page (#17566) · 14919fe1
      Claire authored
      * Change old moderation strikes to be displayed in a separate page
      
      Fixes #17552
      
      This changes the moderation strikes displayed on `/auth/edit` to be those from
      the past 3 months, and make all moderation strikes targeting the current user
      available in `/disputes`.
      
      * Add short description of what the strikes page is for
      
      * Move link to list of strikes to “Account status” instead of navigation item
      
      * Normalize i18n file
      
      * Fix layout and styling of strikes link
      
      * Revert highlights_on regexp
      
      * Reintroduce account status summary
      
      - this way, “Account status” is never empty
      - account status is not necessarily bound to strikes, or recent strikes
      14919fe1
  27. Feb 14, 2022
    • Eugen Rochko's avatar
      Add appeals (#17364) · 564efd06
      Eugen Rochko authored
      * Add appeals
      
      * Add ability to reject appeals and ability to browse pending appeals in admin UI
      
      * Add strikes to account page in settings
      
      * Various fixes and improvements
      
      - Add separate notification setting for appeals, separate from reports
      - Fix style of links in report/strike header
      - Change approving an appeal to not restore statuses (due to federation complexities)
      - Change style of successfully appealed strikes on account settings page
      - Change account settings page to only show unappealed or recently appealed strikes
      
      * Change appealed_at to overruled_at
      
      * Fix missing method error
      564efd06
  28. Jan 23, 2022
    • Claire's avatar
      Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) · bddd9ba3
      Claire authored
      * Remove support for OAUTH_REDIRECT_AT_SIGN_IN
      
      Fixes #15959
      
      Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
      to instead redirect to the external OmniAuth login provider.
      
      However, it did not prevent the log-in form on /about introduced by #10232 from
      appearing, and completely broke with the introduction of #15228.
      
      As I restoring that previous log-in flow without introducing a security
      vulnerability may require extensive care and knowledge of how OmniAuth works,
      this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
      being.
      
      * Add OMNIAUTH_ONLY environment variable to enforce external log-in only
      
      * Disable user registration when OMNIAUTH_ONLY is set to true
      
      * Replace log-in links When OMNIAUTH_ONLY is set with exactly one OmniAuth provider
      bddd9ba3
    • Claire's avatar
      Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287) · cfa583fa
      Claire authored
      Fixes #15959
      
      Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
      to instead redirect to the external OmniAuth login provider.
      
      However, it did not prevent the log-in form on /about introduced by #10232 from
      appearing, and completely broke with the introduction of #15228.
      
      As I restoring that previous log-in flow without introducing a security
      vulnerability may require extensive care and knowledge of how OmniAuth works,
      this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
      being.
      cfa583fa
  29. Jan 16, 2022
  30. Nov 05, 2021
    • Claire's avatar
      Fix reviving revoked sessions and invalidating login (#16943) · 6da135a4
      Claire authored
      Up until now, we have used Devise's Rememberable mechanism to re-log users
      after the end of their browser sessions. This mechanism relies on a signed
      cookie containing a token. That token was stored on the user's record,
      meaning it was shared across all logged in browsers, meaning truly revoking
      a browser's ability to auto-log-in involves revoking the token itself, and
      revoking access from *all* logged-in browsers.
      
      We had a session mechanism that dynamically checks whether a user's session
      has been disabled, and would log out the user if so. However, this would only
      clear a session being actively used, and a new one could be respawned with
      the `remember_user_token` cookie.
      
      In practice, this caused two issues:
      - sessions could be revived after being closed from /auth/edit (security issue)
      - auto-log-in would be disabled for *all* browsers after logging out from one
        of them
      
      This PR removes the `remember_token` mechanism and treats the `_session_id`
      cookie/token as a browser-specific `remember_token`, fixing both issues.
      6da135a4
  31. Sep 30, 2021
  32. Aug 26, 2021
  33. Aug 25, 2021
    • Claire's avatar
      Fix authentication failures after going halfway through a sign-in attempt (#16607) · 94bcf453
      Claire authored
      * Add tests
      
      * Add security-related tests
      
      My first (unpublished) attempt at fixing the issues introduced (extremely
      hard-to-exploit) security vulnerabilities, addressing them in a test.
      
      * Fix authentication failures after going halfway through a sign-in attempt
      
      * Refactor `authenticate_with_sign_in_token` and `authenticate_with_two_factor` to make the two authentication steps more obvious
      94bcf453
    • Daniel's avatar
      Fix undefined variable for Auth::OmniauthCallbacksController (#16654) · 5c210211
      Daniel authored
      The addition of authentication history broke the omniauth login with
      the following error:
      
        method=GET path=/auth/auth/cas/callback format=html
        controller=Auth::OmniauthCallbacksController action=cas status=500
        error='NameError: undefined local variable or method `user' for
        #<Auth::OmniauthCallbacksController:0x00000000036290>
        Did you mean?  @user' duration=435.93 view=0.00 db=36.19
      
      * app/controllers/auth/omniauth_callbacks_controller.rb: fix variable
        name to `@user`
      5c210211
  34. Jun 21, 2021
  35. May 03, 2021
  36. Dec 10, 2020
    • ThibG's avatar
      Add honeypot fields and minimum fill-out time for sign-up form (#15276) · 49eb4d4d
      ThibG authored
      
      * Add honeypot fields to limit non-specialized spam
      
      Add two honeypot fields: a fake website input and a fake password confirmation
      one. The label/placeholder/aria-label tells not to fill them, and they are
      hidden in CSS, so legitimate users should not fall into these.
      
      This should cut down on some non-Mastodon-specific spambots.
      
      * Require a 3 seconds delay before submitting the registration form
      
      * Fix tests
      
      * Move registration form time check to model validation
      
      * Give people a chance to clear the honeypot fields
      
      * Refactor honeypot translation strings
      
      Co-authored-by: default avatarClaire <claire.github-309c@sitedethib.com>
      49eb4d4d
Loading