Skip to content
Snippets Groups Projects
  • Patrick Cloke's avatar
    ba7a91ae
    Refactor oEmbed previews (#10814) · ba7a91ae
    Patrick Cloke authored
    The major change is moving the decision of whether to use oEmbed
    further up the call-stack. This reverts the _download_url method to
    being a "dumb" functionwhich takes a single URL and downloads it
    (as it was before #7920).
    
    This also makes more minor refactorings:
    
    * Renames internal variables for clarity.
    * Factors out shared code between the HTML and rich oEmbed
      previews.
    * Fixes tests to preview an oEmbed image.
    Refactor oEmbed previews (#10814)
    Patrick Cloke authored
    The major change is moving the decision of whether to use oEmbed
    further up the call-stack. This reverts the _download_url method to
    being a "dumb" functionwhich takes a single URL and downloads it
    (as it was before #7920).
    
    This also makes more minor refactorings:
    
    * Renames internal variables for clarity.
    * Factors out shared code between the HTML and rich oEmbed
      previews.
    * Fixes tests to preview an oEmbed image.
10814.feature 85 B