Clean up exception handling in SAML2ResponseResource (#7614)
* Expose `return_html_error`, and allow it to take a Jinja2 template instead of a raw string * Clean up exception handling in SAML2ResponseResource * use the existing code in `return_html_error` instead of re-implementing it (giving it a jinja2 template rather than inventing a new form of template) * do the exception-catching in the REST layer rather than in the handler layer, to make sure we catch all exceptions.
Showing
- changelog.d/7614.misc 1 addition, 0 deletionschangelog.d/7614.misc
- docs/sample_config.yaml 7 additions, 1 deletiondocs/sample_config.yaml
- synapse/config/saml2_config.py 13 additions, 5 deletionssynapse/config/saml2_config.py
- synapse/handlers/saml_handler.py 11 additions, 30 deletionssynapse/handlers/saml_handler.py
- synapse/http/server.py 31 additions, 12 deletionssynapse/http/server.py
- synapse/rest/saml2/response_resource.py 13 additions, 13 deletionssynapse/rest/saml2/response_resource.py
- tox.ini 1 addition, 0 deletionstox.ini
Loading
Please register or sign in to comment