Remove `keylen` from `LruCache`. (#9993)
`keylen` seems to be a thing that is frequently incorrectly set, and we don't really need it. The only time it was used was to figure out if we had removed a subtree in `del_multi`, which we can do better by changing `TreeCache.pop` to return a different type (`TreeCacheNode`). Commits should be independently reviewable.
Showing
- changelog.d/9993.misc 1 addition, 0 deletionschangelog.d/9993.misc
- synapse/replication/slave/storage/client_ips.py 1 addition, 1 deletionsynapse/replication/slave/storage/client_ips.py
- synapse/storage/databases/main/client_ips.py 1 addition, 1 deletionsynapse/storage/databases/main/client_ips.py
- synapse/storage/databases/main/devices.py 1 addition, 1 deletionsynapse/storage/databases/main/devices.py
- synapse/storage/databases/main/events_worker.py 0 additions, 1 deletionsynapse/storage/databases/main/events_worker.py
- synapse/util/caches/deferred_cache.py 0 additions, 2 deletionssynapse/util/caches/deferred_cache.py
- synapse/util/caches/descriptors.py 0 additions, 1 deletionsynapse/util/caches/descriptors.py
- synapse/util/caches/lrucache.py 4 additions, 6 deletionssynapse/util/caches/lrucache.py
- synapse/util/caches/treecache.py 66 additions, 38 deletionssynapse/util/caches/treecache.py
- tests/util/test_lrucache.py 2 additions, 2 deletionstests/util/test_lrucache.py
- tests/util/test_treecache.py 4 additions, 2 deletionstests/util/test_treecache.py
Loading
Please register or sign in to comment