Skip to content
Snippets Groups Projects
Unverified Commit cf3b8156 authored by Richard van der Hoff's avatar Richard van der Hoff Committed by GitHub
Browse files

Fix errorcode for disabled registration (#8867)

The spec says we should return `M_FORBIDDEN` when someone tries to register and
registration is disabled.
parent 66f75c5b
No related branches found
No related tags found
No related merge requests found
Fix the error code that is returned when a user tries to register on a homeserver on which new-user registration has been disabled.
......@@ -451,7 +451,7 @@ class RegisterRestServlet(RestServlet):
# == Normal User Registration == (everyone else)
if not self._registration_enabled:
raise SynapseError(403, "Registration has been disabled")
raise SynapseError(403, "Registration has been disabled", Codes.FORBIDDEN)
# For regular registration, convert the provided username to lowercase
# before attempting to register it. This should mean that people who try
......
......@@ -121,6 +121,7 @@ class RegisterRestServletTestCase(unittest.HomeserverTestCase):
self.assertEquals(channel.result["code"], b"403", channel.result)
self.assertEquals(channel.json_body["error"], "Registration has been disabled")
self.assertEquals(channel.json_body["errcode"], "M_FORBIDDEN")
def test_POST_guest_registration(self):
self.hs.config.macaroon_secret_key = "test"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment