Stop trying to fetch events with event_id=None. (#5753)
`None` is not a valid event id, so queuing up a database fetch for it seems like a silly thing to do. I considered making `get_event` return `None` if `event_id is None`, but then its interaction with `allow_none` seemed uninituitive, and strong typing ftw.
Showing
- changelog.d/5753.misc 1 addition, 0 deletionschangelog.d/5753.misc
- synapse/handlers/message.py 7 additions, 1 deletionsynapse/handlers/message.py
- synapse/storage/events_worker.py 4 additions, 1 deletionsynapse/storage/events_worker.py
- synapse/storage/stats.py 11 additions, 9 deletionssynapse/storage/stats.py
Loading
Please register or sign in to comment