- Dec 02, 2020
-
-
Richard van der Hoff authored
UIA: offer only available auth flows
-
Richard van der Hoff authored
-
Richard van der Hoff authored
-
Richard van der Hoff authored
During user-interactive auth, do not offer password auth to users with no password, nor SSO auth to users with no SSO. Fixes #7559.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
A few test cases were relying on being able to mount non-client servlets on the test resource. it's better to give them their own Resources.
-
Patrick Cloke authored
Replaces the `federation_ip_range_blacklist` configuration setting with an `ip_range_blacklist` setting with wider scope. It now applies to: * Federation * Identity servers * Push notifications * Checking key validitity for third-party invite events The old `federation_ip_range_blacklist` setting is still honored if present, but with reduced scope (it only applies to federation and identity servers).
-
Erik Johnston authored
We do state res with unpersisted events when calculating the new current state of the room, so that should be the only thing impacted. I don't think this is tooooo big of a deal as: 1. the next time a state event happens in the room the current state should correct itself; 2. in the common case all the unpersisted events' auth events will be pulled in by other state, so will still return the correct result (or one which is sufficiently close to not affect the result); and 3. we mostly use the state at an event to do important operations, which isn't affected by this.
-
Richard van der Hoff authored
Rather than using a single JsonResource, construct a resource tree, as we do in the prod code, and allow testcases to add extra resources by overriding `create_resource_dict`.
-
Johanna Dorothea Reichmann authored
The official dashboard uses data from these rules, but they were never added to the synapse-v2.rules. They are mentioned in this issue: https://github.com/matrix-org/synapse/issues/7917#issuecomment-661330409 , but never got added to the rules. Adding them results in all graphs in the "Event persist rate" section to function as intended. Signed-off-by:
Johanna Dorothea Reichmann <transcaffeine@finallycoffee.eu>
-
David Florness authored
Raise a proper 400 error if the `mac` field is missing.
-
Patrick Cloke authored
-
Patrick Cloke authored
-
Patrick Cloke authored
This was broken in #8801 when abstracting code shared with OIDC. After this change both SAML and OIDC have a concept of grandfathering users, but with different implementations.
-
Patrick Cloke authored
-
Richard van der Hoff authored
The idea here is to abstract out all the conditional code which tests which methods a given password provider has, to provide a consistent interface.
-
Andrew Morgan authored
This PR adds a `room_version` argument to the `RestHelper`'s `create_room_as` function for tests. I plan to use this for testing knocking, which currently uses an unstable room version.
-
- Dec 01, 2020
-
-
Richard van der Hoff authored
The spec requires synapse to support `identifier` dicts for `m.login.password` user-interactive auth, which it did not (instead, it required an undocumented `user` parameter.) To fix this properly, we need to pull the code that interprets `identifier` into `AuthHandler.validate_login` so that it can be called from the UIA code. Fixes #5665.
-
Richard van der Hoff authored
It's important that we make sure our background updates happen in a defined order, to avoid disasters like #6923. Add an ordering to all of the background updates that have landed since #7190.
-
Nicolas Chamo authored
-
Richard van der Hoff authored
Fix a minor bug where we would offer "m.login.password" login if a custom auth provider supported it, even if password login was disabled.
-
Richard van der Hoff authored
These things seemed to be completely untested, so I added a load of tests for them.
-
Richard van der Hoff authored
This test was broken by #8565. It doesn't need to set set `self.clock` here anyway - that is done by `setUp`.
-
Andrew Morgan authored
A word got removed accidentally in 83434df3.
-
- Nov 30, 2020
-
-
Richard van der Hoff authored
we don't need to support legacy login dictionaries here.
-
Mathieu Velten authored
This applies even if the feature is disabled at the server level with `allow_per_room_profiles`. The server notice not being a real user it doesn't have an user profile.
-
Richard van der Hoff authored
-
Andrew Morgan authored
Add a config option to change whether unread push notification counts are per-message or per-room (#8820) This PR adds a new config option to the `push` section of the homeserver config, `group_unread_count_by_room`. By default Synapse will group push notifications by room (so if you have 1000 unread messages, if they lie in 55 rooms, you'll see an unread count on your phone of 55). However, it is also useful to be able to send out the true count of unread messages if desired. If `group_unread_count_by_room` is set to `false`, then with the above example, one would see an unread count of 1000 (email anyone?).
-
Jonathan de Jong authored
Changes `@cache_in_self` to use underscore-prefixed attributes.
-
Richard van der Hoff authored
-
- Nov 27, 2020
-
-
Tulir Asokan authored
* Remove special case of pretty printing JSON responses for curl Signed-off-by:
Tulir Asokan <tulir@maunium.net>
-
Andrew Morgan authored
This PR grew out of #6739, and adds typing to some method arguments You'll notice that there are a lot of `# type: ignores` in here. This is due to the base methods not matching the overloads here. This is necessary to stop mypy complaining, but a better solution is #8828.
-
- Nov 26, 2020
-
-
Dirk Klimpel authored
Signed-off-by:
Dirk Klimpel <dirk@klimpel.org>
-
Erik Johnston authored
We can get a SIGHUP at any point, including times where we are not in a sane state. By deferring calling the handlers until the next reactor tick we ensure that we don't get unexpected conflicts, e.g. trying to flush logs from the signal handler while the code was in the process of writing a log entry. Fixes #8769.
-
Dmitry Borodaenko authored
When server URL provided to register_new_matrix_user includes path component (e.g. "http://localhost:8008/" ), the command fails with "ERROR! Received 400 Bad Request". Stripping trailing slash from the server_url command argument makes sure combined endpoint URL remains valid. Signed-off-by:
Dmitry Borodaenko <angdraug@debian.org>
-
Dirk Klimpel authored
-
- Nov 25, 2020
-
-
Dirk Klimpel authored
These are now only available via `/_synapse/admin/v1`.
-
Andrew Morgan authored
This PR updates the push config's formatting to better align with our [code style guidelines](https://github.com/matrix-org/synapse/blob/develop/docs/code_style.md#configuration-file-format).
-
Andrew Morgan authored
This is another PR that grew out of #6739. The existing code for checking whether a user is currently invited to a room when they want to leave the room looks like the following: https://github.com/matrix-org/synapse/blob/f737368a26bb9eea401fcc3a5bdd7e0b59e91f09/synapse/handlers/room_member.py#L518-L540 It calls `get_invite_for_local_user_in_room`, which will actually query *all* rooms the user has been invited to, before iterating over them and matching via the room ID. It will then return a tuple of a lot of information which we pull the event ID out of. I need to do a similar check for knocking, but this code wasn't very efficient. I then tried to write a different implementation using `StateHandler.get_current_state` but this actually didn't work as we haven't *joined* the room yet - we've only been invited to it. That means that only certain tables in Synapse have our desired `invite` membership state. One of those tables is `local_current_membership`. So I wrote a store method that just queries that table instead
-