Skip to content
Snippets Groups Projects
  1. Aug 19, 2021
  2. Aug 18, 2021
  3. Aug 17, 2021
  4. Aug 16, 2021
  5. Aug 11, 2021
  6. Aug 10, 2021
  7. Aug 09, 2021
  8. Aug 06, 2021
    • Erik Johnston's avatar
    • Richard van der Hoff's avatar
      Clean up federation event auth code (#10539) · 1bebc0b7
      Richard van der Hoff authored
      * drop old-room hack
      
      pretty sure we don't need this any more.
      
      * Remove incorrect comment about modifying `context`
      
      It doesn't look like the supplied context is ever modified.
      
      * Stop `_auth_and_persist_event` modifying its parameters
      
      This is only called in three places. Two of them don't pass `auth_events`, and
      the third doesn't use the dict after passing it in, so this should be non-functional.
      
      * Stop `_check_event_auth` modifying its parameters
      
      `_check_event_auth` is only called in three places. `on_send_membership_event`
      doesn't pass an `auth_events`, and `prep` and `_auth_and_persist_event` do not
      use the map after passing it in.
      
      * Stop `_update_auth_events_and_context_for_auth` modifying its parameters
      
      Return the updated auth event dict, rather than modifying the parameter.
      
      This is only called from `_check_event_auth`.
      
      * Improve documentation on `_auth_and_persist_event`
      
      Rename `auth_events` parameter to better reflect what it contains.
      
      * Improve documentation on `_NewEventInfo`
      
      * Improve documentation on `_check_event_auth`
      
      rename `auth_events` parameter to better describe what it contains
      
      * changelog
      Unverified
      1bebc0b7
    • Richard van der Hoff's avatar
      Add a setting to disable TLS for sending email (#10546) · 74d73366
      Richard van der Hoff authored
      This is mostly useful in case the server offers TLS, but doesn't present a valid certificate.
      Unverified
      74d73366
  9. Aug 05, 2021
  10. Aug 04, 2021
  11. Aug 02, 2021
  12. Jul 29, 2021
    • Eric Eastwood's avatar
      Fix backfilled events being rejected for no `state_groups` (#10439) · db6e7f15
      Eric Eastwood authored
      Reproducible on a federated homeserver when there is a membership auth event as a floating outlier. Then when we try to backfill one of that persons messages, it has missing membership auth to fetch which caused us to mistakenly replace the `context` for the message with that of the floating membership `outlier` event. Since `outliers` have no `state` or `state_group`, the error bubbles up when we continue down the persisting route: `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
      
      Call stack:
      
      ```
      backfill
      _auth_and_persist_event
      _check_event_auth
      _update_auth_events_and_context_for_auth
      ```
      Unverified
      db6e7f15
  13. Jul 28, 2021
  14. Jul 27, 2021
Loading