Skip to content
Snippets Groups Projects
  1. Dec 14, 2020
    • Patrick Cloke's avatar
    • Richard van der Hoff's avatar
      Preparatory refactoring of the OidcHandlerTestCase (#8911) · 895e0431
      Richard van der Hoff authored
      * Remove references to handler._auth_handler
      
      (and replace them with hs.get_auth_handler)
      
      * Factor out a utility function for building Requests
      
      * Remove mocks of `OidcHandler._map_userinfo_to_user`
      
      This method is going away, so mocking it out is no longer a valid approach.
      
      Instead, we mock out lower-level methods (eg _remote_id_from_userinfo), or
      simply allow the regular implementation to proceed and update the expectations
      accordingly.
      
      * Remove references to `OidcHandler._map_userinfo_to_user` from tests
      
      This method is going away, so we can no longer use it as a test point. Instead
      we build mock "callback" requests which we pass into `handle_oidc_callback`,
      and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`.
      Unverified
      895e0431
  2. Dec 11, 2020
  3. Dec 09, 2020
  4. Dec 04, 2020
  5. Dec 02, 2020
  6. Dec 01, 2020
  7. Nov 30, 2020
  8. Nov 25, 2020
  9. Nov 19, 2020
  10. Nov 17, 2020
  11. Nov 16, 2020
  12. Nov 03, 2020
  13. Oct 29, 2020
    • Erik Johnston's avatar
      Add ability for access tokens to belong to one user but grant access to another user. (#8616) · f21e24ff
      Erik Johnston authored
      We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't).
      
      A future PR will add an API for creating such a token.
      
      When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.
      Unverified
      f21e24ff
  14. Oct 26, 2020
    • Erik Johnston's avatar
      Start fewer opentracing spans (#8640) · 2b7c1808
      Erik Johnston authored
      #8567 started a span for every background process. This is good as it means all Synapse code that gets run should be in a span (unless in the sentinel logging context), but it means we generate about 15x the number of spans as we did previously.
      
      This PR attempts to reduce that number by a) not starting one for send commands to Redis, and b) deferring starting background processes until after we're sure they're necessary.
      
      I don't really know how much this will help.
      Unverified
      2b7c1808
  15. Oct 23, 2020
  16. Oct 14, 2020
    • Erik Johnston's avatar
      Fix not sending events over federation when using sharded event persisters (#8536) · 921a3f8a
      Erik Johnston authored
      * Fix outbound federaion with multiple event persisters.
      
      We incorrectly notified federation senders that the minimum persisted
      stream position had advanced when we got an `RDATA` from an event
      persister.
      
      Notifying of federation senders already correctly happens in the
      notifier, so we just delete the offending line.
      
      * Change some interfaces to use RoomStreamToken.
      
      By enforcing use of `RoomStreamTokens` we make it less likely that
      people pass in random ints that they got from somewhere random.
      Unverified
      921a3f8a
  17. Oct 13, 2020
  18. Oct 09, 2020
  19. Oct 08, 2020
  20. Oct 07, 2020
  21. Oct 06, 2020
  22. Oct 05, 2020
  23. Oct 01, 2020
  24. Sep 30, 2020
Loading