- Dec 18, 2020
-
-
Erik Johnston authored
This had two effects 1) it'd give the wrong answer and b) would iterate *all* power levels in the auth chain of each event. The latter of which can be *very* expensive for certain types of IRC bridge rooms that have large numbers of power level changes.
-
Richard van der Hoff authored
The final part (for now) of my work to implement a username picker in synapse itself. The idea is that we allow `UsernameMappingProvider`s to return `localpart=None`, in which case, rather than redirecting the browser back to the client, we redirect to a username-picker resource, which allows the user to enter a username. We *then* complete the SSO flow (including doing the client permission checks). The static resources for the username picker itself (in https://github.com/matrix-org/synapse/tree/rav/username_picker/synapse/res/username_picker) are essentially lifted wholesale from https://github.com/matrix-org/matrix-synapse-saml-mozilla/tree/master/matrix_synapse_saml_mozilla/res. As the comment says, we might want to think about making them customisable, but that can be a follow-up. Fixes #8876.
-
Patrick Cloke authored
-
Erik Johnston authored
If we see stale extremities while persisting events, and notice that they don't change the result of state resolution, we drop them.
-
- Dec 17, 2020
-
-
Erik Johnston authored
Co-authored-by:
Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
-
Richard van der Hoff authored
-
Brendan Abolivier authored
* Use the simple dictionary in fts for the user directory * Clarify naming
-
Erik Johnston authored
-
Dirk Klimpel authored
Fixes a bug that deactivated users appear in the directory when their profile information was updated. To change profile information of deactivated users is neccesary for example you will remove displayname or avatar. But they should not appear in directory. They are deactivated. Co-authored-by:
Erik Johnston <erikj@jki.re>
-
Dirk Klimpel authored
-
- Dec 16, 2020
-
-
Patrick Cloke authored
-
Richard van der Hoff authored
This is another part of my work towards fixing #8876. It moves some of the logic currently in the SAML and OIDC handlers - in particular the call to `AuthHandler.complete_sso_login` down into the `SsoHandler`.
-
Patrick Cloke authored
This improves type hinting and should use less memory.
-
- Dec 15, 2020
-
-
Richard van der Hoff authored
... so that we can test its behaviour when it raises. Also pull it out to the top level so that I can use it from other test classes.
-
Richard van der Hoff authored
The tests that need this all do it already.
-
Richard van der Hoff authored
despite the warnings saying "don't implement get_extra_attributes", we had implemented it, so the tests weren't doing what we thought they were.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
This was never used, so let's get rid of it.
-
Richard van der Hoff authored
this didn't seem to be doing a lot, so remove it.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
-
Richard van der Hoff authored
The two are equivalent, but really we want to check the HTTP result that got returned to the channel, not the code that the Request object *intended* to return to the channel.
-
Richard van der Hoff authored
* move simple_async_mock to test_utils ... so that it can be re-used * Remove references to `SamlHandler._map_saml_response_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead, factor out a higher-level method which takes a SAML object, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`. * changelog
-
- Dec 14, 2020
-
-
Richard van der Hoff authored
-
Patrick Cloke authored
-
Richard van der Hoff authored
* Remove references to handler._auth_handler (and replace them with hs.get_auth_handler) * Factor out a utility function for building Requests * Remove mocks of `OidcHandler._map_userinfo_to_user` This method is going away, so mocking it out is no longer a valid approach. Instead, we mock out lower-level methods (eg _remote_id_from_userinfo), or simply allow the regular implementation to proceed and update the expectations accordingly. * Remove references to `OidcHandler._map_userinfo_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead we build mock "callback" requests which we pass into `handle_oidc_callback`, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`.
-
- Dec 11, 2020
-
-
David Teller authored
Spam checker modules can now provide async methods. This is implemented in a backwards-compatible manner.
-
Patrick Cloke authored
-
Dirk Klimpel authored
-
Erik Johnston authored
Fixes #8866
-
- Dec 09, 2020
-
-
Patrick Cloke authored
This defaults `ip_range_blacklist` to reserved IP ranges and also adds an `ip_range_whitelist` setting to override it.
-
Patrick Cloke authored
-
Richard van der Hoff authored
* Consistently use room_id from federation request body Some federation APIs have a redundant `room_id` path param (see https://github.com/matrix-org/matrix-doc/issues/2330). We should make sure we consistently use either the path param or the body param, and the body param is easier. * Kill off some references to "context" Once upon a time, "rooms" were known as "contexts". I think this kills of the last references to "contexts".
-
- Dec 08, 2020
-
-
Aaron Raimist authored
Fixes / related to: https://github.com/matrix-org/synapse/issues/6533 This should do essentially the same thing as a robots.txt file telling robots to not index the media repo. https://developers.google.com/search/reference/robots_meta_tag Signed-off-by:
Aaron Raimist <aaron@raim.ist>
-
- Dec 07, 2020
-
-
Will Hunt authored
* Call set_avatar_url with target_user, not user_id Fixes https://github.com/matrix-org/synapse/issues/8871 * Create 8872.bugfix * Update synapse/rest/admin/users.py Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com> * Testing * Update changelog.d/8872.bugfix Co-authored-by:
Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by:
Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
-
Patrick Cloke authored
-
- Dec 04, 2020
-
-
Patrick Cloke authored
Authentication is done by checking a shared secret provided in the Synapse configuration file.
-
Erik Johnston authored
This is so that we can choose which algorithm to use based on the room ID.
-
Patrick Cloke authored
Pusher URLs now must end in `/_matrix/push/v1/notify` per the specification.
-
Patrick Cloke authored
This was broken in #8801.
-