Skip to content
Snippets Groups Projects
  1. Oct 09, 2020
  2. Sep 28, 2020
  3. Sep 25, 2020
    • Richard van der Hoff's avatar
      Fix occasional "Re-starting finished log context" from keyring (#8398) · fec6f9ac
      Richard van der Hoff authored
      * Fix test_verify_json_objects_for_server_awaits_previous_requests
      
      It turns out that this wasn't really testing what it thought it was testing
      (in particular, `check_context` was turning failures into success, which was
      making the tests pass even though it wasn't clear they should have been.
      
      It was also somewhat overcomplex - we can test what it was trying to test
      without mocking out perspectives servers.
      
      * Fix warnings about finished logcontexts in the keyring
      
      We need to make sure that we finish the key fetching magic before we run the
      verifying code, to ensure that we don't mess up our logcontexts.
      Unverified
      fec6f9ac
  4. Sep 04, 2020
  5. Aug 27, 2020
  6. Aug 03, 2020
  7. Jul 30, 2020
  8. Jul 09, 2020
  9. Mar 24, 2020
    • Richard van der Hoff's avatar
      Clean up some LoggingContext stuff (#7120) · 39230d21
      Richard van der Hoff authored
      * Pull Sentinel out of LoggingContext
      
      ... and drop a few unnecessary references to it
      
      * Factor out LoggingContext.current_context
      
      move `current_context` and `set_context` out to top-level functions.
      
      Mostly this means that I can more easily trace what's actually referring to
      LoggingContext, but I think it's generally neater.
      
      * move copy-to-parent into `stop`
      
      this really just makes `start` and `stop` more symetric. It also means that it
      behaves correctly if you manually `set_log_context` rather than using the
      context manager.
      
      * Replace `LoggingContext.alive` with `finished`
      
      Turn `alive` into `finished` and make it a bit better defined.
      Unverified
      39230d21
  10. Jan 06, 2020
  11. Oct 30, 2019
  12. Jul 23, 2019
  13. Jul 19, 2019
  14. Jul 03, 2019
  15. Jun 10, 2019
    • Erik Johnston's avatar
      Fix key verification when key stored with null valid_until_ms · 43badd2c
      Erik Johnston authored
      Some keys are stored in the synapse database with a null valid_until_ms
      which caused an exception to be thrown when using that key. We fix this
      by treating nulls as zeroes, i.e. they keys will match verification
      requests with a minimum_valid_until_ms of zero (i.e. don't validate ts)
      but will not match requests with a non-zero minimum_valid_until_ms.
      
      Fixes #5391.
      43badd2c
  16. Jun 06, 2019
    • Richard van der Hoff's avatar
      Stop hardcoding trust of old matrix.org key (#5374) · 9fbb20a5
      Richard van der Hoff authored
      There are a few changes going on here:
      
      * We make checking the signature on a key server response optional: if no
        verify_keys are specified, we trust to TLS to validate the connection.
      
      * We change the default config so that it does not require responses to be
        signed by the old key.
      
      * We replace the old 'perspectives' config with 'trusted_key_servers', which
        is also formatted slightly differently.
      
      * We emit a warning to the logs every time we trust a key server response
        signed by the old key.
      Unverified
      9fbb20a5
  17. Jun 05, 2019
  18. Jun 03, 2019
  19. May 24, 2019
  20. May 23, 2019
  21. May 10, 2019
  22. Apr 11, 2019
  23. Apr 08, 2019
  24. Apr 04, 2019
  25. Apr 03, 2019
  26. Nov 27, 2018
  27. Aug 13, 2018
  28. Aug 10, 2018
  29. Jul 09, 2018
  30. Jun 22, 2018
  31. Apr 15, 2018
  32. Jan 27, 2018
    • Richard van der Hoff's avatar
      Create dbpool as normal in tests · d7eacc4f
      Richard van der Hoff authored
      ... instead of creating our own special SQLiteMemoryDbPool, whose purpose was a
      bit of a mystery.
      
      For some reason this makes one of the tests run slightly slower, so bump the
      sleep(). Sorry.
      d7eacc4f
  33. Jan 16, 2018
    • Richard van der Hoff's avatar
      Optimise LoggingContext creation and copying · 44a49841
      Richard van der Hoff authored
      It turns out that the only thing we use the __dict__ of LoggingContext for is
      `request`, and given we create lots of LoggingContexts and then copy them every
      time we do a db transaction or log line, using the __dict__ seems a bit
      redundant. Let's try to optimise things by making the request attribute
      explicit.
      44a49841
  34. Sep 20, 2017
Loading