Different users may be allowed to see different rooms within a space,
so sharing responses between users is inadvisable.

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

It already seems to pass mypy. I wonder what changed, given that it was
on the exclusion list. So this commit consists of me ensuring
`--disallow-untyped-defs` passes and a minor fixup to a function that
returned either `True` or `None`.

* Add support for the stable version of MSC2778

Signed-off-by: Tulir Asokan <tulir@maunium.net>

* Expect m.login.application_service in login and password provider tests

Signed-off-by: Tulir Asokan <tulir@maunium.net>

* Prefer `HTTPStatus` over plain `int`

This is an Opinion that no-one has seemed to object to yet.

* `--disallow-untyped-defs` for `tests.rest.client.test_directory`
* Improve synapse's annotations for deleting aliases
* Test case for deleting a room alias
* Changelog

* change display names/avatar URLS to None if they contain null bytes

* add changelog

* add POC test, requested changes

* add a saner test and remove old one

* update test to verify that display name has been changed to None

* make test less fragile

* Annotate HomeserverTestCase.servlets
* Correct annotation of federation_auth_origin
* Use AnyStr custom_headers instead of a Union

This allows (str, str) and (bytes, bytes).
This disallows (str, bytes) and (bytes, str)

* DomainSpecificString.SIGIL is a ClassVar

Signed-off-by: Dirk Klimpel <dirk@klimpel.org>

as of #11012, these parameters are unused.

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Adds experimental support for `relation_types` and `relation_senders`
fields for filters.

When fetching remote devices for the first time, we did not correctly include the cross signing keys in the returned results.

c.f. #11159

Co-authored-by: reivilibre <olivier@librepush.net>

Fixes #11259

We might as well use a default value for `public_baseurl` based on
`server_name` - in many cases, it will be correct.

Fixes #11252

I was trying to understand how `cachedList` works, and ended up writing this
extra test. I figure we may as well keep it.

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Fixes: #10874
Signed-off-by: Dirk Klimpel <dirk@klimpel.org>

* add code to handle missing content-type header and a test to verify that it works

* add handling for missing content-type in the /upload endpoint as well

* slightly refactor test code to put private method in approriate place

* handle possible null value for content-type when pulling from the local db

* add changelog

* refactor test and add code to handle missing content-type in cached remote media

* requested changes

* Update changelog.d/11200.bugfix

Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>

Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>

Make `check_event_allowed` module API callback not fail open (accept events) when an exception is raised (#11033)

Remove deprecated delete room admin API,
`POST /_synapse/admin/v1/rooms/<room_id>/delete`

Fixes https://github.com/matrix-org/synapse/issues/8308

Signed-off-by: Rafael Goncalves <rafaelgoncalves@riseup.net>

Fetch verify key locally rather than trying to do so over federation if origin and host are the same. (#11129)

* add tests for fetching key locally

* add logic to check if origin server is same as host and fetch verify key locally rather than over federation

* add changelog

* slight refactor, add docstring, change changelog entry

* Make changelog entry one line

* remove verify_json_locally and push locality check to process_request, add function process_request_locally

* remove leftover code reference

* refactor to add common call to 'verify_json and associated handling code

* add type hint to process_json

* add some docstrings + very slight refactor

Co-authored-by: reivilibre <oliverw@matrix.org>

Fixes: #9346

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>