Skip to content
Snippets Groups Projects
  1. Feb 24, 2021
    • Erik Johnston's avatar
      Clean up `ShardedWorkerHandlingConfig` (#9466) · 29279219
      Erik Johnston authored
      * Split ShardedWorkerHandlingConfig
      
      This is so that we have a type level understanding of when it is safe to
      call `get_instance(..)` (as opposed to `should_handle(..)`).
      
      * Remove special cases in ShardedWorkerHandlingConfig.
      
      `ShardedWorkerHandlingConfig` tried to handle the various different ways
      it was possible to configure federation senders and pushers. This led to
      special cases that weren't hit during testing.
      
      To fix this the handling of the different cases is moved from there and
      `generic_worker` into the worker config class. This allows us to have
      the logic in one place and allows the rest of the code to ignore the
      different cases.
      29279219
    • Erik Johnston's avatar
      Refactor to ensure we call check_consistency (#9470) · 0b5c9678
      Erik Johnston authored
      The idea here is to stop people forgetting to call `check_consistency`. Folks can still just pass in `None` to the new args in `build_sequence_generator`, but hopefully they won't.
      0b5c9678
  2. Feb 23, 2021
  3. Feb 22, 2021
  4. Feb 19, 2021
  5. Feb 18, 2021
  6. Feb 17, 2021
Loading