Skip to content
Snippets Groups Projects
  1. Nov 16, 2021
  2. Nov 12, 2021
    • David Robertson's avatar
      Misc typing fixes for `tests`, part 1 of N (#11323) · 4c96ce39
      David Robertson authored
      * Annotate HomeserverTestCase.servlets
      * Correct annotation of federation_auth_origin
      * Use AnyStr custom_headers instead of a Union
      
      This allows (str, str) and (bytes, bytes).
      This disallows (str, bytes) and (bytes, str)
      
      * DomainSpecificString.SIGIL is a ClassVar
      4c96ce39
  3. Oct 14, 2021
  4. Oct 06, 2021
  5. Oct 04, 2021
    • David Robertson's avatar
      Consistently exclude from user_directory (#10960) · f7b034a2
      David Robertson authored
      * Introduce `should_include_local_users_in_dir`
      
      We exclude three kinds of local users from the user_directory tables. At
      present we don't consistently exclude all three in the same places. This
      commit introduces a new function to gather those exclusion conditions
      together. Because we have to handle local and remote users in different
      ways, I've made that function only consider the case of remote users.
      It's the caller's responsibility to make the local versus remote
      distinction clear and correct.
      
      A test fixup is required. The test now hits a path which makes db
      queries against the users table. The expected rows were missing, because
      we were using a dummy user that hadn't actually been registered.
      
      We also add new test cases to covert the exclusion logic.
      
      ----
      
      By my reading this makes these changes:
      
      * When an app service user registers or changes their profile, they will
        _not_ be added to the user directory. (Previously only support and
        deactivated users were excluded). This is consistent with the logic that
        rebuilds the user directory. See also [the discussion
        here](https://github.com/matrix-org/synapse/pull/10914#discussion_r716859548
      
      ).
      * When rebuilding the directory, exclude support and disabled users from
        room sharing tables. Previously only appservice users were excluded.
      * Exclude all three categories of local users when rebuilding the
        directory. Previously `_populate_user_directory_process_users` didn't do
        any exclusion.
      
      Co-authored-by: default avatarRichard van der Hoff <1389908+richvdh@users.noreply.github.com>
      f7b034a2
    • Patrick Cloke's avatar
  6. Oct 01, 2021
  7. Sep 30, 2021
  8. Sep 29, 2021
  9. Sep 10, 2021
  10. Aug 20, 2021
  11. Jul 19, 2021
  12. Jul 13, 2021
  13. Apr 27, 2021
  14. Apr 23, 2021
  15. Apr 20, 2021
  16. Apr 14, 2021
  17. Apr 09, 2021
  18. Apr 08, 2021
  19. Mar 17, 2021
  20. Mar 16, 2021
  21. Feb 16, 2021
  22. Jan 28, 2021
  23. Jan 07, 2021
  24. Dec 18, 2020
  25. Dec 15, 2020
  26. Dec 02, 2020
  27. Nov 25, 2020
  28. Nov 16, 2020
  29. Nov 15, 2020
  30. Nov 05, 2020
Loading