Skip to content
Snippets Groups Projects
  1. Jun 10, 2020
  2. Jun 09, 2020
    • Brendan Abolivier's avatar
    • Brendan Abolivier's avatar
      Revert "1.15.0rc1" · 2dc9468c
      Brendan Abolivier authored
      This reverts commit 8587b042.
      2dc9468c
    • Brendan Abolivier's avatar
      1.15.0rc1 · 8587b042
      Brendan Abolivier authored
      8587b042
    • Erik Johnston's avatar
      Fix bug in account data replication stream. (#7656) · 664409b1
      Erik Johnston authored
      * Ensure account data stream IDs are unique.
      
      The account data stream is shared between three tables, and the maximum
      allocated ID was tracked in a dedicated table. Updating the max ID
      happened outside the transaction that allocated the ID, leading to a
      race where if the server was restarted then the same ID could be
      allocated but the max ID failed to be updated, leading it to be reused.
      
      The ID generators have support for tracking across multiple tables, so
      we may as well use that instead of a dedicated table.
      
      * Fix bug in account data replication stream.
      
      If the same stream ID was used in both global and room account data then
      the getting updates for the replication stream would fail due to
      `heapq.merge(..)` trying to compare a `str` with a `None`. (This is
      because you'd have two rows like `(534, '!room')` and `(534, None)` from
      the room and global account data tables).
      
      Fix is just to order by stream ID, since we don't rely on the ordering
      beyond that. The bug where stream IDs can be reused should be fixed now,
      so this case shouldn't happen going forward.
      
      Fixes #7617
      664409b1
  3. Jun 08, 2020
  4. Jun 05, 2020
  5. Jun 04, 2020
  6. Jun 03, 2020
  7. Jun 02, 2020
  8. Jun 01, 2020
Loading