Skip to content
Snippets Groups Projects
  1. Oct 29, 2020
  2. Oct 28, 2020
  3. Oct 27, 2020
  4. Oct 26, 2020
  5. Oct 23, 2020
  6. Oct 22, 2020
  7. Oct 21, 2020
  8. Oct 20, 2020
  9. Oct 19, 2020
  10. Oct 16, 2020
  11. Oct 15, 2020
  12. Oct 14, 2020
  13. Oct 13, 2020
  14. Oct 12, 2020
    • Erik Johnston's avatar
      Make event persisters periodically announce position over replication. (#8499) · 8de3703d
      Erik Johnston authored
      Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress.
      
      This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.
      Unverified
      8de3703d
  15. Oct 09, 2020
    • Patrick Cloke's avatar
    • Richard van der Hoff's avatar
      Fix threadsafety in ThreadedMemoryReactorClock (#8497) · 9789b1fb
      Richard van der Hoff authored
      This could, very occasionally, cause:
      
      ```
      tests.test_visibility.FilterEventsForServerTestCase.test_large_room
      ===============================================================================
      [ERROR]
      Traceback (most recent call last):
        File "/src/tests/rest/media/v1/test_media_storage.py", line 86, in test_ensure_media_is_in_local_cache
          self.wait_on_thread(x)
        File "/src/tests/unittest.py", line 296, in wait_on_thread
          self.reactor.advance(0.01)
        File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 826, in advance
          self._sortCalls()
        File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 787, in _sortCalls
          self.calls.sort(key=lambda a: a.getTime())
      builtins.ValueError: list modified during sort
      
      tests.rest.media.v1.test_media_storage.MediaStorageTests.test_ensure_media_is_in_local_cache
      ```
      Unverified
      9789b1fb
Loading