It's a simplification, but one that'll help make the user directory logic easier
to follow with the other changes upcoming. It's not strictly required for those
changes, but this will help simplify the resulting logic that listens for
`m.room.member` events and generally make the logic easier to follow.

This means the config option `search_all_users` ends up controlling the
search query only, and not the data we store. The cost of doing so is an
extra row in the `user_directory` and `user_directory_search` tables for
each local user which

- belongs to no public rooms
- belongs to no private rooms of size ≥ 2

I think the cost of this will be marginal (since they'll already have entries
 in `users` and `profiles` anyway).

As a small upside, a homeserver whose directory was built with this
change can toggle `search_all_users` without having to rebuild their
directory.

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Allow membership event to unban user

Signed-off-by: Aaron Raimist <aaron@raim.ist>

To avoid duplicating it between a few tests.

Also enables Mypy for related tests.

Instead of proxying through the magic getter of the RootConfig
object. This should be more performant (and is more explicit).

By copying the `room_type` field of the create event and
migrating any non-empty `m.space.child` events to the
new room that is created.

No functional changes here. This came out as I was working to tackle #5677 

Signed-off-by: Sean Quah <seanq@element.io>

This is only called in two places, and the code seems much clearer without it.

Outlier events don't ever have push actions associated with them, so we
can skip some expensive queries during event persistence.

This adds the format to the request arguments / URL to
ensure that JSON data is returned (which is all that
Synapse supports).

This also adds additional error checking / filtering to the
configuration file to ignore XML-only providers.

This avoids breaking the entire endpoint if a room with
an unsupported room version is encountered.

This updates the ordering of the returned events from the spaces
summary API to that defined in MSC2946 (which updates MSC1772).

Previously a step was skipped causing ordering to be inconsistent with
clients.

Part of https://github.com/matrix-org/synapse/pull/10566

 - Fill in creator whenever we insert into the rooms table
 - Add background update to backfill any missing creator values

Judging by the template, this was intended ages ago, but we never
actually passed an avatar URL to the template. So let's provide one.

Closes #1546.

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

This adds configuration options (under an `oembed` section) to
configure which URLs are matched to use oEmbed for URL
previews.

These were broken in an incorrect merge of GHSA-jj53-8fmw-f2w2 (cb35df94)

* Add some tests to characterise the problem

Some failing. Current states:

  RoomsMemberListTestCase
test_get_member_list ...
[OK]
test_get_member_list_mixed_memberships ...
[OK]
test_get_member_list_no_permission ...
[OK]
test_get_member_list_no_permission_former_member ...
[OK]
test_get_member_list_no_permission_former_member_with_at_token ...
[FAIL]
test_get_member_list_no_room ...
[OK]
test_get_member_list_no_permission_with_at_token ...
[FAIL]

* Correct the tests

* Check user is/was member before divulging room membership

* Pull out only the 1 membership event we want.

* Update tests/rest/client/v1/test_rooms.py

Co-authored-by: Erik Johnston <erik@matrix.org>

* Fixup tests (following apply review suggestion)

Co-authored-by: Erik Johnston <erik@matrix.org>

Turns out that the functionality added in #10546 to skip TLS was incompatible
with older Twisted versions, so we need to be a bit more inventive.

Also, add a test to (hopefully) not break this in future. Sadly, testing TLS is
really hard.

Fixes: #9544

The idea here is to take anything to do with incoming events and move it out to a separate handler, as a way of making FederationHandler smaller.

Signed-off-by: Aaron Raimist <aaron@raim.ist>

When a user deletes an email from their account it will
now also remove all pushers for that email and that user
(even if these pushers were created by a different client)

Fixes #10318

Signed-off-by: Callum Brown <callum@calcuode.com>

This is part of my GSoC project implementing [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231).

By replacing duplicated code with parameterized tests and
avoiding unnecessary dumping of JSON data.

Merged before approval; these comments from @clokep on that PR.

* Validate device_keys for C-S /keys/query requests

Closes #10354

A small, not particularly critical fix. I'm interested in seeing if we
can find a more systematic approach though. #8445 is the place for any discussion.

Here we split on_receive_pdu into two functions (on_receive_pdu and process_pulled_event), rather than having both cases in the same method. There's a tiny bit of overlap, but not that much.

A user will still see this room if it is in a local cache, but it will
not reappear if clearing the cache and reloading.