Skip to content
Snippets Groups Projects
  1. Sep 21, 2021
  2. Sep 20, 2021
  3. Sep 17, 2021
  4. Sep 16, 2021
  5. Sep 15, 2021
  6. Sep 14, 2021
    • reivilibre's avatar
      Make StateFilter frozen so we can hash it (#10816) · 8eb7cb2e
      reivilibre authored
      Also enables Mypy for related tests.
      8eb7cb2e
    • Sean Quah's avatar
      Prevent logging context going missing on federation request timeout (#10810) · 14b8c047
      Sean Quah authored
      In `MatrixFederationHttpClient._send_request()`, we make a HTTP request
      using an `Agent`, wrap that request in a timeout and await the resulting
      `Deferred`. On its own, the `Agent` performing the HTTP request
      correctly stashes and restores the logging context while waiting.
      The addition of the timeout introduces a path where the logging context
      is not restored when execution resumes.
      
      To address this, we wrap the timeout `Deferred` in a
      `make_deferred_yieldable()` to stash the logging context and restore it
      on completion of the `await`. However this is not sufficient, since by
      the time we construct the timeout `Deferred`, the `Agent` has already
      stashed and cleared the logging context when using
      `make_deferred_yieldable()` to produce its `Deferred` for the request.
      
      Hence, we wrap the `Agent` request in a `run_in_background()` to "fork"
      and preserve the logging context so that we can stash and restore it
      when `await`ing the timeout `Deferred`.
      
      This approach is similar to the one used with `defer.gatherResults`.
      
      Note that the code is still not fully correct. When a timeout occurs,
      the request remains running in the background (existing behavior which
      is nothing to do with the new call to `run_in_background`) and may
      re-start the logging context after it has finished.
      14b8c047
    • Patrick Cloke's avatar
      Convert media repo's FileInfo to attrs. (#10785) · b996782d
      Patrick Cloke authored
      This is mostly an internal change, but improves type hints in the
      media code.
      b996782d
    • Andrew Morgan's avatar
      1.43.0rc1 · d725e095
      Andrew Morgan authored
      d725e095
    • David Robertson's avatar
      Name the type of token in "Invalid token" messages (#10815) · 319b8b6b
      David Robertson authored
      I had one of these error messages yesterday and assumed it was an
      invalid auth token (because that was an HTTP query parameter in the
      test) I was working on. In fact, it was an invalid next batch token for
      syncing.
      319b8b6b
  7. Sep 13, 2021
  8. Sep 10, 2021
  9. Sep 09, 2021
  10. Sep 08, 2021
Loading