Consider using { cmd1; cmd2; } >> file instead of individual redirects.

https://github.com/koalaman/shellcheck/wiki/SC2129



Signed-off-by: Dan Callahan <danc@element.io>

Double quote to prevent globbing and word splitting.

https://github.com/koalaman/shellcheck/wiki/SC2086



Signed-off-by: Dan Callahan <danc@element.io>

Use find instead of ls to better handle non-alphanumeric filenames.

https://github.com/koalaman/shellcheck/wiki/SC2012



Signed-off-by: Dan Callahan <danc@element.io>

Expressions don't expand in single quotes, use double quotes for that.

https://github.com/koalaman/shellcheck/wiki/SC2016



This specifically warned about the '$aregis...' part of the sed script.
Which is a relatively obscure use of sed.

Splitting this into two commands makes its intent more obvious and
avoids contravening Shellcheck's lints.

Signed-off-by: Dan Callahan <danc@element.io>

Not following: (error message here)

https://github.com/koalaman/shellcheck/wiki/SC1091



Signed-off-by: Dan Callahan <danc@element.io>

This \o will be a regular 'o' in this context.

https://github.com/koalaman/shellcheck/wiki/SC1001



Signed-off-by: Dan Callahan <danc@element.io>

SC2089: Quotes/backslashes will be treated literally. Use an array.

https://github.com/koalaman/shellcheck/wiki/SC2089

SC2090: Quotes/backslashes in this variable will not be respected.

https://github.com/koalaman/shellcheck/wiki/SC2090



Putting literal JSON in a variable mistakenly triggers these warnings.
Instead of adding ignore directives, this can be avoided by inlining the
JSON data into the curl invocation.

Since the variable is only used in this one location, inlining is fine.

Signed-off-by: Dan Callahan <danc@element.io>

Declare and assign separately to avoid masking return values.

https://github.com/koalaman/shellcheck/wiki/SC2155



Signed-off-by: Dan Callahan <danc@element.io>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

https://github.com/koalaman/shellcheck/wiki/SC2166



Signed-off-by: Dan Callahan <danc@element.io>

var is referenced but not assigned.

https://github.com/koalaman/shellcheck/wiki/SC2154



Signed-off-by: Dan Callahan <danc@element.io>

Use single quotes, otherwise this expands now rather than when signalled.

https://github.com/koalaman/shellcheck/wiki/SC2064



Signed-off-by: Dan Callahan <danc@element.io>

Use "${var:?}" to ensure this never expands to /* .

https://github.com/koalaman/shellcheck/wiki/SC2115



Signed-off-by: Dan Callahan <danc@element.io>

Quote this to prevent word splitting

https://www.shellcheck.net/wiki/SC2046



Signed-off-by: Dan Callahan <danc@element.io>

Use `cd ... || exit` in case cd fails.

https://github.com/koalaman/shellcheck/wiki/SC2164



Signed-off-by: Dan Callahan <danc@element.io>

`synapse.config.__main__` has the possibility to read a config item. This can be used to conveniently also validate the config is valid before trying to start Synapse.

 The "read" command broke in https://github.com/matrix-org/synapse/pull/10916

 as it now requires passing in "server.server_name" for example.

 Also made the read command optional so one can just call this with just the confirm file reference and get a "Config parses OK" if things are ok.

Signed-off-by: Jason Robinson <jasonr@matrix.org>
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>

Adds experimental support for MSC3440's `io.element.thread` relation
type (and the aggregation for it).

* We only need to fetch users in private rooms

* Filter out `user_id` at the top

* Discard excluded users in the top loop

We weren't doing this in the "First, if they're our user" branch so this
is a bugfix.

* The caller must check that `user_id` is included

This is in the docstring. There are two call sites:
- one in `_handle_room_publicity_change`, which explicitly checks before calling;
- and another in `_handle_room_membership_event`, which returns early if
  the user is excluded.

So this change is safe.

* Test joining a private room with an excluded user

* Tweak an existing test

* Changelog

* test docstring

* lint

And require type hints for this module.

relative links don't work when it's on dockerhub.

Fix setting a user's external_id via the admin API returns 500 and deletes users existing external mappings if that external ID is already mapped (#11051)

Fixes #10846

It's been possible to configure a key inline in the homeserver.yaml since
13bc1e07. Update `sign_json` to work with this.

Signed-off-by: Robert Edström <github@legogris.se>

Remove some redundant code, and generally simplify.

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Mention callbacks introduced in v1.37.0

According to the documentation introduced in https://github.com/matrix-org/synapse/pull/10062

* Mention callbacks introduced in v1.39.0

According to https://github.com/matrix-org/synapse/pull/10386 and https://github.com/matrix-org/synapse/pull/9884

* Mention callbacks introduced in v1.42.0

According to https://github.com/matrix-org/synapse/pull/10524

* Mention callbacks introduced in v1.44.0 and v1.45.0

As per https://github.com/matrix-org/synapse/pull/10898, https://github.com/matrix-org/synapse/pull/10910 and https://github.com/matrix-org/synapse/pull/10894

* Mention callbacks introduced in v1.46.0

According to https://github.com/matrix-org/synapse/pull/10548

Temporarily revert "Add functionality to remove deactivated users from the monthly_active_users table (#10947)".

This reverts commit eda8c88b.

Updates the event rows returned from the database to be
attrs classes instead of dictionaries.

Signed-off-by: Dan Callahan <danc@element.io>